Avoid infinite loop by raising an exception if not connected #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbldh
requested changes
Aug 24, 2019
There was a problem hiding this comment.
This wil cancel the connection attempt on the first time the properties["Connected"] is False, making the while loop unncecessary, right? I am not sure I want to throw the connection attempt away the first time this happens. Make the loop go for say 3-5 seconds before rasing the error and I am fine with merging this.
d013da4 to
174c0f0
Compare
|
Good point, I added a 5 seconds timeout before failing. |
hbldh
approved these changes
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an exception in the infinite loop of
get_servicesif the fieldConnectedis not found in the properties.Sometimes we can get stuck in this loop if the connection drops between the connect and the service discovery.
Either we should raise an exception there or return and raise it in the caller.