Register a disconnected callback and clean up subscriptions on disconnect #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbldh
requested changes
Jul 16, 2019
bleak/backends/client.py
Outdated
| # Connectivity methods | ||
|
|
||
| @abc.abstractmethod | ||
| async def set_disconnect_callback( |
There was a problem hiding this comment.
I would like some documentation of an example of a disconnect_callback that shows how it is used. Place it here, in the docstring of the interface class.
There was a problem hiding this comment.
Makes sense. I'll add it tomorrow.
bleak/backends/bluezdbus/client.py
Outdated
| self._rules = {} | ||
| self._subscriptions = list() | ||
|
|
||
| self.disconnect_callback = None |
There was a problem hiding this comment.
Could you change this to an internal attribute, please?
The callback will be called only on unsolicited disconnect event from peer. An initiated disconnect from the host will not call it. Other implementations (Core Bluetooth and .NET) will fail with a NotImplementedError exception.
If a client subscribed to characteristics, disconnected and reconnected, the old subscriptions stayed registered. If a new subscription to notifications were added, the data was received twice on every callback. This patch makes sure that the BleakClient keeps track of the active subscriptions and explicitly removes them when a disconnect is called as part of its cleanup.
8190755 to
7e39ca4
Compare
|
@hbldh I implemented the changes and rebased on the develop branch. I was not aware of this branch before... |
hbldh
added a commit
that referenced
this pull request
Aug 2, 2019
Implemented new method stumps (due to abstract methods) from #86 in macOS and Windows backends as well. Modified example files to show how Core Bluetooth backend handles addresses. Removed corebleak.py, since I do not think it is needed any more either.
hbldh
added a commit
that referenced
this pull request
Aug 2, 2019
macOS support added (thanks to @kevincar) Merged #80: macOS development Merged #90 which fixed #89: Leaking callbacks in BlueZ Merged #92 which fixed #91, Prevent leaking of DBus connections on discovery Merged #96: Regex patterns Merged #86 which fixed #83 and #82 Recovered old .NET discovery method to try for #95
hbldh
added a commit
that referenced
this pull request
Sep 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch contains two changes:
Replaces #85
Fixes #83
Closes #82