Use raw literals for regex patterns #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbldh
requested changes
Jul 30, 2019
bleak/backends/bluezdbus/utils.py
Outdated
|
|
||
| _mac_address_regex = re.compile("^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$") | ||
| _hci_device_regex = re.compile("^hci(\d+)$") | ||
| _mac_address_regex = re.compile(r'^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$') |
There was a problem hiding this comment.
This row does not need to be changed. The code formatter black, which I use for bleak, will change your single quotes to doubles very soon. The string also does not need to be binary. I.e. Remove this change.
bleak/backends/bluezdbus/utils.py
Outdated
| _mac_address_regex = re.compile("^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$") | ||
| _hci_device_regex = re.compile("^hci(\d+)$") | ||
| _mac_address_regex = re.compile(r'^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$') | ||
| _hci_device_regex = re.compile(r'^hci(\d+)$') |
There was a problem hiding this comment.
I would rather see this changed to
_hci_device_regex = re.compile("^hci(\\d+)$")
That woudl remove the warning and keep it as a regular string.
fea3d27 to
7740566
Compare
hbldh
approved these changes
Aug 1, 2019
hbldh
added a commit
that referenced
this pull request
Aug 1, 2019
hbldh
added a commit
that referenced
this pull request
Aug 2, 2019
macOS support added (thanks to @kevincar) Merged #80: macOS development Merged #90 which fixed #89: Leaking callbacks in BlueZ Merged #92 which fixed #91, Prevent leaking of DBus connections on discovery Merged #96: Regex patterns Merged #86 which fixed #83 and #82 Recovered old .NET discovery method to try for #95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix this Python 3 related warning: