Fix leaking of callbacks from DBus on multiple calls to discover() #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0c7e8b to
50ecd8d
Compare
If the rules are only added to Bluez via DBus but never removed again, the calls pile up if discover() is called multiple times in one session. This is especially harmful for long-running applications that connect and disconnect to the same or different servers over and over. The time to await discovery() becomes very long (up to minutes) even with smaller timeouts. Make sure the callbacks registered are cleaned up before discover() is left.
50ecd8d to
e4c59f6
Compare
hbldh
added a commit
that referenced
this pull request
Jul 16, 2019
Merge branch 'workaroundgmbh-fix/bluez/callback_leak' into develop
|
Merged this into develop branch. Will close this when I release 0.5.0. |
hbldh
added a commit
that referenced
this pull request
Aug 2, 2019
macOS support added (thanks to @kevincar) Merged #80: macOS development Merged #90 which fixed #89: Leaking callbacks in BlueZ Merged #92 which fixed #91, Prevent leaking of DBus connections on discovery Merged #96: Regex patterns Merged #86 which fixed #83 and #82 Recovered old .NET discovery method to try for #95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the rules are only added to Bluez via DBus but never removed again,
the calls pile up if discover() is called multiple times in one session.
This is especially harmful for long-running applications that connect
and disconnect to the same or different servers over and over. The time
to await discovery() becomes very long (up to minutes) even with smaller
timeouts.
Make sure the callbacks registered are cleaned up before discover() is
left.
Fixes #89