Pin pooch and be compliant with future versions #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1272 1272
Branches 124 124
=========================================
Hits 1272 1272
Continue to review full report at Codecov.
|
ernestoarbitrio
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With pooch 1.5.0 the import with
from pooch.utils import file_hashdoesn't work anymore, even though they claim to not change the public API (fatiando/pooch#244).However, we need to stay with pooch 1.4.0 to be compatible with skimage == 1.17.2 (we need to remember to upgrade the pin when we merge #196).
Anyway I changed the code to be compliant with both versions.
Types of Changes
Issues Fixed or Closed by This PR
Checklist