Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Pin pooch and be compliant with future versions #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alessiamarcolini merged 1 commit into from
Aug 23, 2021
Merged

Pin pooch and be compliant with future versions #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
python -m pip install -e .[testing]
python -m pip install flake8==3.8.4
python -m pip install black==21.6b0
python -m pip install pooch
python -m pip install pooch==1.4.0

- name: Black Code Style Format Check
id: black
Expand Down
2 changes: 1 addition & 1 deletion src/histolab/data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
histolab_distribution_dir = os.path.join(legacy_data_dir, "..")

try:
from pooch.utils import file_hash
from pooch import file_hash
except ModuleNotFoundError:
# Function taken from
# https://github.com/fatiando/pooch/blob/master/pooch/utils.py
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/data/test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ def test_pooch_missing(monkeypatch):
from histolab import data

fakesysmodules = copy.copy(sys.modules)
fakesysmodules["pooch.utils"] = None
monkeypatch.delitem(sys.modules, "pooch.utils")
fakesysmodules["pooch"] = None
monkeypatch.delitem(sys.modules, "pooch")
monkeypatch.setattr("sys.modules", fakesysmodules)
file = SVS.CMU_1_SMALL_REGION
reload(data)
Expand All @@ -129,8 +129,8 @@ def test_file_hash_with_wrong_algorithm(monkeypatch):
from histolab import data

fakesysmodules = copy.copy(sys.modules)
fakesysmodules["pooch.utils"] = None
monkeypatch.delitem(sys.modules, "pooch.utils")
fakesysmodules["pooch"] = None
monkeypatch.delitem(sys.modules, "pooch")
monkeypatch.setattr("sys.modules", fakesysmodules)
file = SVS.CMU_1_SMALL_REGION
reload(data)
Expand Down