Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add cellularity score #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolebussola merged 2 commits into from
Sep 22, 2021
Merged

add cellularity score #320

nicolebussola merged 2 commits into from
Sep 22, 2021

Conversation

@nicolebussola
Copy link
Collaborator

@nicolebussola nicolebussola commented Sep 21, 2021

Issue #306

@codecov
Copy link

codecov bot commented Sep 21, 2021 •
edited
Loading

Codecov Report

Merging #320 (7d43a5b) into master (41ea99c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #320   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1285      1294    +9     
  Branches       124       124           
=========================================
+ Hits          1285      1294    +9
Impacted Files Coverage Δ
src/histolab/scorer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41ea99c...7d43a5b. Read the comment docs.

alessiamarcolini
alessiamarcolini requested changes Sep 21, 2021
View reviewed changes
alessiamarcolini
alessiamarcolini approved these changes Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! I'm not sure about the milestone though

@nicolebussola nicolebussola linked an issue Sep 21, 2021 that may be closed by this pull request
Hematoxylin scorer #306
Closed
@nicolebussola nicolebussola merged commit 7bbdefb into master Sep 22, 2021
@nicolebussola nicolebussola deleted the cecllularity_score branch September 22, 2021 08:36
@alessiamarcolini alessiamarcolini added this to the 0.2.7 milestone Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernestoarbitrio ernestoarbitrio ernestoarbitrio approved these changes

@alessiamarcolini alessiamarcolini alessiamarcolini approved these changes

@kheffah kheffah kheffah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

Hematoxylin scorer

5 participants

@nicolebussola @ernestoarbitrio @alessiamarcolini @kheffah