Data mix fix #366
Merged
Data mix fix #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
…g_format Signed-off-by: Aakanksha Duggal <[email protected]>
Signed-off-by: Aakanksha Duggal <[email protected]>
Member
|
@Mergifyio backport release-v0.3 |
Contributor
✅ Backports have been createdDetails
|
bbrowning
approved these changes
Nov 12, 2024
Contributor
bbrowning
left a comment
There was a problem hiding this comment.
Looks good to me - verified locally that this does add the pretraining samples into the phase10 dataset. I wrote a small unit test to verify this locally, so will create a follow-up PR to get that merged as well without blocking or adding to this one.
Member
Author
|
Thanks @bbrowning for your review. I do have some tests in flight that I can add as a follow up PR. |
Contributor
|
Great - will hold off on turning my simple verification into an actual PR then and defer to you on that. Thanks for following up! |
khaledsulayman
approved these changes
Nov 12, 2024
Member
khaledsulayman
left a comment
There was a problem hiding this comment.
I've also tested this on an ec2 with full mixtral and looks good!
bbrowning
added a commit
that referenced
this pull request
Nov 13, 2024
Data mix fix (backport #366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #365