You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code has changed between releases here, so this automatic backport failed. We'll need to manually adjust the code to work with the older version of SDG here.
@aakankshaduggal I adjusted this backport of your PR to work with SDG 0.3.x - it's a pretty straightforward change to remove the use_legacy_pretraining_format stuff, but please review to ensure it looks correct to you.
Hmm, got caught by some other changes preventing CI from passing on this backport - will have to open a separate backport PR, get that one merged, and then maybe we can get this one green.
Older versions of SDG did not have the `use_legacy_pretraining_format`
parameter, so this just removes that from the backported code.
Signed-off-by: Ben Browning <[email protected]>
I will need to investigate why mergify didn't auto-merge this, but it looks like just a gap in the auto-merge rules at least for this release branch. Merging manually since all tests passed and it has multiple approvals.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #365
This is an automatic backport of pull request #366 done by Mergify.