Fix for empty string value from pyvenv.cfg parsing #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2023
scop
reviewed
Aug 14, 2023
|
@elebertus @scop I think now is perfect time to merge this fix! Please! |
zero length string comparison Co-authored-by: Ville Skyttä <[email protected]>
|
@scop good to go, pulled in your suggestion 👍 |
|
Cheers! However I think we'll need to wait for @justjanne to have a look, I have no commit access here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*ini.File.Section.Keywill return a zero-length value (stringin this case since it's cast tostring) which evaluates to an emptyenvand thenenvNamevalue.Here we maintain the same functionality but check if the value is empty, if empty retain the value from
VIRTUAL_ENVforenv.This fixes #373