I recommend this be shipped and included in the github-pages gem a.s.a.p

The consequence of this change is that people with custom footer.html will not get the new social links. That's commendable.

This seems like a lot of flip-flopping. Hopefully, this doesn't risk making more confusion, rather than less. This avoids broken builds, but could also produce users who ask "Why can't I use the new social links?"

So will these includes be deleted in minima 3.0?

@ashawley The most important is not to break builds for the thousands of people that are using minima and don't care for the update. It's fair to say that when we ship 3.0, we will document the upgrade and remove those.

The most important is not to break builds for the thousands of people that are using minima

I'm just trying to discuss the change so we can review it.

I'm sure there are "thousands of people" using minima, but how many people have sourced the existing footer.html file?

No matter how many people customized their footer, we don't want to break their site. We'll be more cautious next time and use post-install message to notify for breaking changes.

There appear to be about 30,000 public users of minima on Github alone:

https://github.com/search?q=minima+language%3AYAML&type=Code

But only a dozen over 68,000 people who have a footer.html referencing the old social files.

https://github.com/search?q=icon-twitter+path%3A_includes+language%3AHTML&type=Code

@ashawley You only count public repos.

You only count public repos.

Yes, I meant to qualify that and forgot. Thanks.

At that scale, you can understand the proportions/probability of a custom footer.html, regardless.

FWIW this broke my build and was pretty frustrating trying to work out why without much help from jekyll's error message:

"Failure: A file was included in /_layouts/default.html that is a symlink or does not exist in your _includes directory."

I wasn't in your search @ashawley despite having a public repo so your number is probably low.

@nathanKramer This PR is a fix for the issue you mentioned.. Did you update to Minima-2.4.1? If you were simply referencing a past experience, then ignore this comment..

Is the github-pages gem going to get updated with this fix?

https://github.com/github/pages-gem/releases