-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
LaTeX: Handle bold inside tt #8129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the review! I moved the function to Shared, but I couldn't find the other reader you were talking about. |
1a56301 to
03458fd
Compare
|
Sorry for all the force-pushes. I've cleaned some stuff up and I tihnk it's looking better now. |
|
I want to suggest these changes, which I think clarify the code even further, and also give us the flexibility to add attributes to the Code elements. |
|
Done, thanks! Unfortunately I can't remove |
I don't think that's true! Remember, |
You're right, my apologies! I missed the |
|
Looks good except for a small typo in the comment. |
|
Perfect, thanks for all your help! I can work on a second PR after this is merged. |
add `formatCode` function to Shared to parse e.g.
`\texttt{\textbf{bold code}}` as `Strong [Code ("",[],[]) "bold code"]`
|
Great, thanks! |
parse
\texttt{\textbf{bold code}}asStrong [Code ("",[],[]) "bold code"]closes #7525