use formatCode function in some more readers
#8162
Conversation
|
I'm not sure what happened with CI. That test passes locally. |
|
The muse reader tests include some nondeterministic roundtrip tests. |
|
Ah, got it. I reran the tests with the |
There was a problem hiding this comment.
You're right about the failing test, it is unrelated to the changes here. The test has now been removed.
The HTML change looks good (but see my inline comment); I don't think reStructuredText supports markup in code, and I'm unsure about the others. Could you verify that these changes are correct?
|
Good point about RST not supporting formatting within code. I removed the readers that don't support it. Thanks for the review! |
|
I'd suggest updating the commit message so it's more informative. We use these to create the changelog. Say which readers you've changed, and what the change does, and link to the issue adding formatCode, as you did in the PR description above. |
move formatting from inside inline code elements to the outside in order to retain formatting
|
Thanks! |
Use
formatCodefunction from #8129 inThese readers were chosen arbitrarily and I am happy to add more or revert any, if anyone more familiar with the project has any input.