Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

rsov
Copy link
Contributor

@rsov rsov commented Jul 12, 2018

This is a quick fix for #432 and #430

@mengu
Copy link

mengu commented Jul 12, 2018

hi @rsov

if i may, where does the refresh_paths method come from?

@rsov
Copy link
Contributor Author

rsov commented Jul 12, 2018

@mengu Sorry, I meant clear_paths. And it comes from rubygems: https://www.rubydoc.info/stdlib/rubygems/Gem.clear_paths

@kares
Copy link
Member

kares commented Jul 13, 2018

very nice, method has existed way long (at least since RGs 2.0) ... makes sense to reset.

@mengu
Copy link

mengu commented Jul 13, 2018

@rsov, and i meant reload_paths :-)

if reload_path is not an alias for clear_paths, reload_paths does not exist in the Gem module hence the merged PR will raise an exception.

@kares
Copy link
Member

kares commented Jul 13, 2018

oh right, clear_paths is mentioned so I checked that one - seems there isn't such method at RubyGems.
could we maybe not shoot for such breaking (non-mergable) PRs next time please?
if you'd like to show up in a comment that you have smt in mind you could just point them to a commit ...

@mengu
Copy link

mengu commented Jul 13, 2018

well, i didn't know we could jump in for a code review. next time i'll surely do that.

@rsov
Copy link
Contributor Author

rsov commented Jul 13, 2018

Indeed. I have made a mistake. I could push up the fixed code or if you like, can troubleshoot to see if it can be fixed somewhere upstream. Unless there's a fix coming in the next version of jruby

kares added a commit that referenced this pull request Aug 23, 2018
* 'master' of github.com:jruby/warbler:
  Include `gem_build_complete_path` in jar (#439)
  Revert "[fix] gem path reloading when delpoying on 9.2.x ..." (#434)
  [fix] gem path reloading when delpoying on 9.2.x (#433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants