Include gem_build_complete_path in jar
#439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Gem::Specification#missing_extensions?` uses this file to determine if a gem has properly completed building extensions.
|
would have been interesting to have a test-case for this, please keep the repo around for a while just in case we need to revert and examine - not going deep down the rabbit hole for now |
|
@kares the build files included by this may cause issues when switching java versions, since the build complete path includes the java version the gem was built on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gem::Specification#missing_extensions?uses this file to determine ifa gem has properly completed building extensions.
I ran into a couple issues with gems getting bundled but then not being
available when running the jar because
missing_extensions?was true.This change got things working for me, though there may be a better way
to fix the issue.
Here's an example repo that shows the issue and fix: https://github.com/davishmcclurg/warbler-bug
I generated a Rails project under JRuby and added the thrift gem to break
the generated war file. The commits show how to reproduce.