Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JanBerktold
Copy link

Support for customized colors including the ability to mix font and background colors by using a Flag-based description of the colors.

Any questions, thoughts or feedback? :)

@k0kubun
Copy link
Owner

k0kubun commented Feb 25, 2015

Thank you for sending a pull request.

But before reviewing your idea and detail implementation, I have a question. Why did you delete printer_test.go?
It is a very important test to keep backward compatibility. If you want to change this library, you should pass the existing tests.

@JanBerktold
Copy link
Author

Ooops, completely missed out on that! Sorry!

Will fix this evening.

@k0kubun
Copy link
Owner

k0kubun commented Feb 25, 2015

Ooops, completely missed out on that! Sorry!

That's ok. :)

@JanBerktold
Copy link
Author

All right, found some time:

  • I've re-added printer_test.go
  • Found & fixed some missed bugs

However, I've had to change printer_test.go as it previously expected the bold setting after the color and my code did it the other way around. Is that fine?

@k0kubun
Copy link
Owner

k0kubun commented Feb 25, 2015

I've re-added printer_test.go

Thank you. I can see this branch's behavior on wercker CI and it looks good.

However, I've had to change printer_test.go as it previously expected the bold setting after the color and my code did it the other way around. Is that fine?

I don't mind the order of bold setting and color.

Though I don't still read code well, I can tell this change does not need 17 steps. Could you rebase and squash the commits to make each commit's purpose clear?

@JanBerktold
Copy link
Author

Attempted to break it down into less commits. Is it fine?

However, (somehow) I've managed to include one of the previous commits. Do you happen to know how I can remove it from my pull request?

@k0kubun
Copy link
Owner

k0kubun commented Feb 26, 2015

Attempted to break it down into less commits. Is it fine?

That's fine. Thanks.

However, (somehow) I've managed to include one of the previous commits.
Do you happen to know how I can remove it from my pull request?

This branch needs git rebase against k0kubun/pp's master branch. It may possibly be easier to re-create a new pull request.

@sdidyk sdidyk mentioned this pull request Apr 25, 2015
@k0kubun
Copy link
Owner

k0kubun commented Apr 25, 2015

Resolved by #17.
Thank you for proposing a nice feature.

@k0kubun k0kubun closed this Apr 25, 2015
k0kubun pushed a commit that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants