-
Couldn't load subscription status.
- Fork 109
Add support for customized colors #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for sending a pull request. But before reviewing your idea and detail implementation, I have a question. Why did you delete printer_test.go? |
|
Ooops, completely missed out on that! Sorry! Will fix this evening. |
That's ok. :) |
|
All right, found some time:
However, I've had to change printer_test.go as it previously expected the bold setting after the color and my code did it the other way around. Is that fine? |
Thank you. I can see this branch's behavior on wercker CI and it looks good.
I don't mind the order of bold setting and color. Though I don't still read code well, I can tell this change does not need 17 steps. Could you rebase and squash the commits to make each commit's purpose clear? |
|
Attempted to break it down into less commits. Is it fine? However, (somehow) I've managed to include one of the previous commits. Do you happen to know how I can remove it from my pull request? |
That's fine. Thanks.
This branch needs git rebase against k0kubun/pp's master branch. It may possibly be easier to re-create a new pull request. |
|
Resolved by #17. |
Support for customized colors including the ability to mix font and background colors by using a Flag-based description of the colors.
Any questions, thoughts or feedback? :)