Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sdidyk
Copy link
Contributor

@sdidyk sdidyk commented Apr 25, 2015

I've slightly refactored code by @JanBerktold (pull request #14) and have rebased it on master.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep the color of - and : because a current behavior is the same as pry.
Just applying currentScheme.Time to only numbers would be better for me.
ref: #11

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed in fa6ef26

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, my fault. Premature optimization.

@k0kubun
Copy link
Owner

k0kubun commented Apr 25, 2015

Nice work. LGTM with a comment. Merging for now.

k0kubun added a commit that referenced this pull request Apr 25, 2015
@k0kubun k0kubun merged commit 6dbdb47 into k0kubun:master Apr 25, 2015
k0kubun added a commit that referenced this pull request Apr 25, 2015
k0kubun pushed a commit that referenced this pull request Oct 6, 2025
…eckout-4

Bump actions/checkout from 3 to 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants