test: fix Victoria dashboard tests in KOF UI #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AndrejsPon00
commented
Sep 10, 2025
- Fix tests that failed due to a new metrics structure
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
e60bc96 to
74b52cb
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes failing tests in the KOF UI's Victoria dashboard by updating test expectations to match a new metrics data structure. The changes address test failures that occurred after Victoria's metrics response format was updated from simple key-value pairs to arrays of metric objects with labels and values.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/victoria_tests/VictoriaTable.test.tsx |
Updated pod name expectations and cluster selection to match new fake data structure |
tests/victoria_tests/VictoriaList.test.tsx |
Fixed expected pod count from 6 to 2 for mothership cluster |
tests/victoria_tests/VictoriaDetailsPage.test.tsx |
Updated component type names and tab count expectations |
tests/fake_data/fake_victoria_response.ts |
Completely restructured fake data to use new array-based metric format |
tests/MetricsCard.test.tsx |
Updated component imports and metric expectations to match new data structure |
src/components/pages/victoriaPage/victoria-details/VictoriaDetailsPage.tsx |
Fixed TabsContent wrapping for Raw Metrics tab |
src/components/pages/collectorPage/components/collector-details/CollectorContent.tsx |
Fixed TabsContent wrapping for Raw Metrics tab |
denis-ryzhkov
requested changes
Sep 10, 2025
74b52cb to
10b9ffa
Compare
|
@AndrejsPon00 please add a step in CI to run tests |
denis-ryzhkov
approved these changes
Sep 10, 2025
gmlexx
requested changes
Sep 10, 2025
|
gmlexx
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.