fix: daemon-collector crashes with authenticator not found
#556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical issue where the daemon-collector component crashes with an "authenticator not found" error. The fix adds missing basicauth extension references to the OpenTelemetry collector service configuration.
Key Changes
- Adds basicauth authenticator extensions for metrics, logs, and traces to the service extensions list
- Ensures the daemon collector can properly authenticate when processing telemetry data
gmlexx
reviewed
Sep 29, 2025
| storage: file_storage/filelogk8sauditreceiver | ||
| service: | ||
| extensions: | ||
| - basicauth/metrics |
Collaborator
There was a problem hiding this comment.
This probably fails the istio deployment as there is no basicauth extension needed.
Collaborator
Author
There was a problem hiding this comment.
- In istio case we don't enable basic auth in exporters:
https://github.com/k0rdent/kof/blob/v1.4.0-rc1/charts/kof-istio/templates/_helpers.tpl#L43 - In non-istio case we do:
https://github.com/k0rdent/kof/blob/v1.4.0-rc1/charts/kof-child/templates/child-multi-cluster-service.yaml#L175 - So in the istio case the basic auth extension would be just unused.
- I'll test istio too anyway later.
Collaborator
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failed to resolve authenticator \"basicauth/logs\": authenticator not foundin child cluster #554