fix: move collectors service extensions list to upper charts values #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #554 by restructuring the OpenTelemetry collector service extensions configuration. The key change moves the extensions list from the lower-level collectors chart to the upper-level charts (kof-child and kof-istio), providing better configuration flexibility and consistency across different deployment scenarios.
- Removes extensions configuration from the base collectors chart
- Adds extensions configuration to parent charts (kof-child and kof-istio)
- Updates monitoring metrics to include collector health checks
- Disables cleanup for Victoria Metrics CRDs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kof-collectors/values.yaml | Removes hardcoded extensions list from daemon collector service configuration |
| charts/kof-child/values.yaml | Adds comprehensive extensions list including authentication and storage extensions |
| charts/kof-istio/values.yaml | Adds complete collectors configuration with service extensions |
| scripts/metrics.py | Adds health monitoring metrics for kof-collectors-daemon-collector |
| charts/kof-storage/values.yaml | Disables CRD cleanup for Victoria Metrics operator |
denis-ryzhkov
requested changes
Sep 29, 2025
fd49509 to
b8ee3eb
Compare
denis-ryzhkov
previously approved these changes
Sep 29, 2025
Collaborator
denis-ryzhkov
left a comment
There was a problem hiding this comment.
Code is great, but CI fails.
b8ee3eb to
8cf2f40
Compare
denis-ryzhkov
previously approved these changes
Sep 29, 2025
8cf2f40 to
6166895
Compare
denis-ryzhkov
previously approved these changes
Sep 29, 2025
6166895 to
5fd4d5c
Compare
denis-ryzhkov
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #554