Upgrade go-github (and the dependants) and pass name option #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sorry, I will check the failure of CI. |
Contributor
Author
|
ah, I checked the failure. |
Contributor
Author
|
I also created a PR to ghfs. So, I change to draft |
Contributor
Author
|
@k1LoW |
Owner
|
@wreulicke Could you rebase or update branch? ( crypto has been updated ) |
8fa3268 to
e42dd90
Compare
Contributor
Author
|
@k1LoW |
Owner
|
@wreulicke Thank you!!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ListArtifacts is used without a name option even though there is in github API reference.
So, I checked the current version of go-github doesn't have that.
But, the latest version of
go-githubhas a name option.So, this PR upgrade go-github (and the dependants) and pass the name to ListArtifacts.