Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[breaking changes] Upgrade go-github and go-github-client #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k1LoW merged 1 commit into from
Feb 28, 2025
Merged

[breaking changes] Upgrade go-github and go-github-client #34

k1LoW merged 1 commit into from
Feb 28, 2025

Conversation

@wreulicke
Copy link
Contributor

@wreulicke wreulicke commented Feb 28, 2025 •
edited
Loading

Upgrade go-github and go-github-client

This PR has breaking changes.
For example, this PR makes ghfs.Client incompatible because *githubv58.Client is not incompatible with *githubv67.Client

func Client(client *github.Client) Option { 
	return func(c *config) error {
		if client != nil {
			c.client = client
		}
		return nil
	}
}

k1LoW/octocov#463 requires this PR.

@wreulicke wreulicke mentioned this pull request Feb 28, 2025
Merged
@k1LoW
Copy link
Owner

k1LoW commented Feb 28, 2025 •
edited
Loading

@wreulicke Thank you! Could you update the branch( or rebase the main)? CI fixes have been completed.

@wreulicke
Copy link
Contributor Author

wreulicke commented Feb 28, 2025

@k1LoW
Thank you for your quick response. I updated!

@k1LoW k1LoW merged commit 1033f88 into k1LoW:main Feb 28, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Feb 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wreulicke @k1LoW