Added GetIndex accessors (alternative to PR#58, which used properties)
#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces GetIndex() accessor methods as an alternative to using properties in global variable instructions. The key changes include adding GetIndex() in both InstGlobalGet and InstGlobalSet classes to provide direct access to the GlobalIdx field.
Comments suppressed due to low confidence (2)
Wacs.Core/Instructions/GlobalVariable.cs:34
- [nitpick] Consider adding XML documentation for the GetIndex method to clarify its purpose and usage.
public GlobalIdx GetIndex() => Index;
Wacs.Core/Instructions/GlobalVariable.cs:135
- [nitpick] Consider adding XML documentation for the GetIndex method to clarify its purpose and usage.
public GlobalIdx GetIndex() => Index;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #58, adding a
GetIndex()function instead of using a property.