Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent exception in the log #22201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhajas merged 1 commit into from
Sep 19, 2023
Merged

Prevent exception in the log #22201

mhajas merged 1 commit into from
Sep 19, 2023

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Aug 2, 2023 •
edited
Loading

Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

The external link check no completes in 2 minutes instead of 9 minutes on GitHub actions.

Closes #22200

@ahus1
Prevent exception in the log
b48d3a2 
Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

Closes keycloak#22200
@ahus1 ahus1 self-assigned this Aug 2, 2023
@ahus1 ahus1 marked this pull request as ready for review August 3, 2023 08:36
@ahus1 ahus1 requested a review from a team as a code owner August 3, 2023 08:36
@ahus1
Copy link
Contributor Author

ahus1 commented Aug 3, 2023

@miquelsi - as you've reviewed PR #22187, I wonder if you'd feel confident to review this PR as well.

It avoids an exception in the log and speeds up the build by a few minutes.

As #22187 hasn't been merged yet, it shows the error in the external links (as it should).

Thanks!

@ahus1 ahus1 requested review from mhajas and miquelsi and removed request for miquelsi August 3, 2023 08:42
@ahus1
Copy link
Contributor Author

ahus1 commented Aug 7, 2023

@mhajas - I wonder if you could have a review for this one when you have the time. Thanks!

mhajas
mhajas reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ahus1, I added one comment.

@ahus1 ahus1 requested a review from mhajas September 6, 2023 14:33
mhajas
mhajas approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahus1

@mhajas mhajas merged commit 41fd12d into keycloak:main Sep 19, 2023
ahus1 added a commit to ahus1/keycloak that referenced this pull request Sep 21, 2023
@ahus1
Prevent exception in the log (keycloak#22201)
b25a785 
Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

Closes keycloak#22200

(cherry picked from commit 41fd12d)
@ahus1 ahus1 mentioned this pull request Sep 21, 2023
Merged
@ahus1 ahus1 deleted the is-22200-prevent-exception-external-link-check-and-speedup branch September 21, 2023 17:05
ahus1 added a commit that referenced this pull request Oct 6, 2023
@ahus1
Prevent exception in the log (#22201)
a8e28f8 
Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

Closes #22200

(cherry picked from commit 41fd12d)
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mhajas mhajas mhajas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

External Link check for documentation logs warning and exception: WARN FilenoUtil: Native subprocess control requires open access

2 participants

@ahus1 @mhajas