Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Backporting documentation PRs #23454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahus1 merged 2 commits into from
Oct 6, 2023
Merged

Backporting documentation PRs #23454

ahus1 merged 2 commits into from
Oct 6, 2023

Conversation

@ahus1
Copy link
Member

@ahus1 ahus1 commented Sep 21, 2023 •
edited
Loading

Those two PRs build on top of each other. As they need to be merged both, I combined them in one PR.

Please just rebase the PR, not squash it. Thanks!

Backporting #22200
Backporting #23345

Original PRs: #22201, #23347

@ahus1
Prevent exception in the log (keycloak#22201)
b25a785 
Also speed up the external link check by avoiding checking each bug submission link in the rendered docs which only differs by its parameter.

Closes keycloak#22200

(cherry picked from commit 41fd12d)
@ahus1
Ignoring link for stackapps registration (keycloak#23347)
3ea0c3f 
It now requires authentication.

Closes keycloak#23345

(cherry picked from commit 5070f41)
@ahus1 ahus1 self-assigned this Sep 21, 2023
@ahus1
Copy link
Member Author

ahus1 commented Sep 21, 2023

@mhajas - as you've reviewed the orginal PRs, I'd be happy if you could have a look and review this PR. Thanks!

@ahus1 ahus1 requested a review from mhajas September 21, 2023 15:18
@ghost ghost added the flaky-test label Sep 21, 2023
This was referenced Sep 21, 2023
Closed
Closed
Closed
@ghost
Copy link

ghost commented Sep 21, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.ConcurrentHashMapStorageTest#testStorageSeparation

Keycloak CI - Store Model Tests

org.keycloak.models.locking.LockAcquiringTimeoutException: Lock [org.keycloak.models.RealmModel] already acquired by keycloak instance [null] at the time [null]
	at org.keycloak.models.map.lock.MapGlobalLockProvider.withLock(MapGlobalLockProvider.java:94)
	at org.keycloak.models.locking.GlobalLockProvider.withLock(GlobalLockProvider.java:45)
	at org.keycloak.models.map.storage.jpa.JpaMapStorageProviderFactory.update(JpaMapStorageProviderFactory.java:549)
	at org.keycloak.models.map.storage.jpa.JpaMapStorageProviderFactory.validateAndUpdateSchema(JpaMapStorageProviderFactory.java:471)
...

Report flaky test

ghost
ghost reviewed Sep 21, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ahus1 ahus1 marked this pull request as ready for review September 21, 2023 16:51
@ahus1 ahus1 requested a review from a team as a code owner September 21, 2023 16:51
@ahus1 ahus1 closed this Sep 21, 2023
@ahus1 ahus1 deleted the is-23345-backport branch September 21, 2023 17:24
@ahus1 ahus1 restored the is-23345-backport branch October 6, 2023 08:12
@ahus1 ahus1 reopened this Oct 6, 2023
@ahus1
Copy link
Member Author

ahus1 commented Oct 6, 2023

reopened, as it was closed accidentially closed when I deleted the branch.

@ahus1 ahus1 removed the request for review from mhajas October 6, 2023 12:16
@ahus1 ahus1 merged commit b2a6b23 into keycloak:release/22.0 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

+2 more reviewers

@sguilhen sguilhen sguilhen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahus1 @sguilhen @pedroigor