Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ignoring link for stackapps registration #23347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhajas merged 1 commit into from
Sep 21, 2023
Merged

Ignoring link for stackapps registration #23347

mhajas merged 1 commit into from
Sep 21, 2023

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Sep 19, 2023

It now requires authentication.

Closes #23345

@ahus1 ahus1 self-assigned this Sep 19, 2023
@ahus1 ahus1 force-pushed the is-23345-fix-stackapps-link branch from 92b6224 to 9623050 Compare September 19, 2023 08:49
@ahus1 ahus1 changed the title Fixing link for stackapps registration Ignoring link for stackapps registration Sep 19, 2023
@ghost ghost added the flaky-test label Sep 19, 2023
This was referenced Sep 19, 2023
Closed
Closed
Closed
Closed
Closed
ghost
ghost reviewed Sep 19, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Sep 19, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.ApplicationsTest#toggleApplicationDetailsTest

Keycloak CI - Account Console IT (firefox)

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/test/protocol/openid-connect/auth ; actual URL: https://localhost:8543/auth/realms/test/account/#/applications within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
...

Report flaky test

@ahus1
Ignoring link for stackapps registration
78373a7 
It now requires authentication.

Closes keycloak#23345
@ahus1 ahus1 force-pushed the is-23345-fix-stackapps-link branch from 9623050 to 78373a7 Compare September 20, 2023 11:37
This was referenced Sep 20, 2023
Closed
Closed
Closed
@ahus1 ahus1 marked this pull request as ready for review September 21, 2023 08:44
@ahus1 ahus1 requested a review from a team as a code owner September 21, 2023 08:44
@ahus1 ahus1 requested a review from mhajas September 21, 2023 08:45
@ahus1
Copy link
Contributor Author

ahus1 commented Sep 21, 2023

@mhajas - could you please review and merge this when you have the time? Thanks!

@ahus1 ahus1 mentioned this pull request Sep 21, 2023
Closed
mhajas
mhajas approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahus1

@mhajas mhajas merged commit 5070f41 into keycloak:main Sep 21, 2023
ahus1 added a commit to ahus1/keycloak that referenced this pull request Sep 21, 2023
@ahus1
Ignoring link for stackapps registration (keycloak#23347)
3ea0c3f 
It now requires authentication.

Closes keycloak#23345

(cherry picked from commit 5070f41)
@ahus1 ahus1 mentioned this pull request Sep 21, 2023
Merged
@ahus1 ahus1 deleted the is-23345-fix-stackapps-link branch September 21, 2023 16:55
ahus1 added a commit that referenced this pull request Oct 6, 2023
@ahus1
Ignoring link for stackapps registration (#23347)
b2a6b23 
It now requires authentication.

Closes #23345

(cherry picked from commit 5070f41)
@stianst stianst mentioned this pull request Nov 14, 2023
Closed
@stianst stianst mentioned this pull request May 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mabartos mabartos mabartos approved these changes

+3 more reviewers

@jonkoops jonkoops jonkoops approved these changes

@mhajas mhajas mhajas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken link https://stackapps.com/apps/oauth/register

4 participants

@ahus1 @jonkoops @mhajas @mabartos