Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Using a valid URI when deleting cookies before/after running tests #25902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedroigor merged 1 commit into from
Jan 5, 2024
Merged

Using a valid URI when deleting cookies before/after running tests #25902

pedroigor merged 1 commit into from
Jan 5, 2024

Conversation

@pedroigor
Copy link
Contributor

@pedroigor pedroigor commented Jan 4, 2024

Closes #22691

@pedroigor pedroigor requested review from a team as code owners January 4, 2024 13:52
@pedroigor pedroigor requested a review from a team January 4, 2024 13:52
@pedroigor pedroigor requested a review from a team as a code owner January 4, 2024 13:52
@ghost ghost added the flaky-test label Jan 4, 2024
This was referenced Jan 4, 2024
Closed
Closed
Closed
Closed
This was referenced Jan 4, 2024
Closed
Closed
@pedroigor pedroigor force-pushed the issue-22691 branch 2 times, most recently from adf84a0 to 4c5c9f0 Compare January 5, 2024 11:17
mposolda
mposolda previously approved these changes Jan 5, 2024
View reviewed changes
@pedroigor
Copy link
Contributor Author

pedroigor commented Jan 5, 2024

FTR, looks like the failure is related to:

1704414581685	addons.xpi	ERROR	System addon update list error SyntaxError: XMLHttpRequest.open: 'http://%(server)s/dummy-system-addons.xml' is not a valid URL.
BrowserFlowTest ++ console.log: "RemoteSettingsWorker error: DataError: IndexedDB: records, timestamps execute() Data provided to an operation does not meet requirements."
BrowserFlowTest ++ console.error: (new RemoteSettingsWorkerError("DataError: IndexedDB: records, timestamps execute() Data provided to an operation does not meet requirements.",

@ahus1 ahus1 self-requested a review January 5, 2024 12:33
ahus1
ahus1 approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My initial comments have been resolved.

@pedroigor pedroigor merged commit d540584 into keycloak:main Jan 5, 2024
@pedroigor pedroigor deleted the issue-22691 branch January 5, 2024 18:13
@cypress
Copy link

cypress bot commented Jan 6, 2024 •
edited
Loading

1 flaky test on run #10413 ↗︎

0 1100 108 0 Flakiness 1

Details:

Using a valid URI when deleting cookies before/after running tests
Project: Keycloak Admin UI Commit: d540584449
Status: Passed Duration: 07:08 💡
Started: Jan 8, 2024 12:22 AM Ended: Jan 8, 2024 12:29 AM
Flakiness  cypress/e2e/clients_test.spec.ts • 1 flaky test • firefox

View Output

Test Artifacts
Clients test > Client details - Client scopes subtab > Should search non-existent client scope by name Screenshots

Review all test suite changes for PR #25902 ↗︎

@pedroigor pedroigor mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

@ahus1 ahus1 ahus1 approved these changes

+1 more reviewer

@jonkoops jonkoops jonkoops approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.forms.RecoveryAuthnCodesAuthenticatorTest#test03AuthenticateRecoveryAuthnCodes

4 participants

@pedroigor @jonkoops @mposolda @ahus1