Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Using a valid URI when deleting cookies before/after running tests #25902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedroigor merged 1 commit into from
Jan 5, 2024
Merged

Using a valid URI when deleting cookies before/after running tests #25902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...estsuite-providers/src/main/java/org/keycloak/testsuite/rest/TestingResourceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
import org.keycloak.services.managers.AuthenticationManager;
import org.keycloak.services.resource.RealmResourceProvider;
import org.keycloak.services.scheduled.ClearExpiredUserSessions;
import org.keycloak.services.util.CacheControlUtil;
import org.keycloak.services.util.CookieHelper;
import org.keycloak.sessions.RootAuthenticationSessionModel;
import org.keycloak.storage.UserStorageProvider;
Expand Down Expand Up @@ -1177,4 +1176,10 @@ public Response getNoCacheAnnotatedEndpointResponse(@QueryParam("programmatic_ma
return Response.noContent().cacheControl(cacheControl).build();
}

@GET
@Path("/blank")
@Produces(MediaType.TEXT_HTML_UTF_8)
public Response getBlankPage() {
return Response.ok("<html><body></body></html>").build();
}
}
17 changes: 16 additions & 1 deletion ...uillian/tests/base/src/main/java/org/keycloak/testsuite/drone/KeycloakDronePostSetup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@
import org.jboss.arquillian.test.spi.annotation.ClassScoped;
import org.jboss.logging.Logger;
import org.keycloak.testsuite.util.WaitUtils;
import org.openqa.selenium.Capabilities;
import org.openqa.selenium.WebDriver;
import org.openqa.selenium.firefox.FirefoxDriver;
import org.openqa.selenium.firefox.FirefoxOptions;
import org.openqa.selenium.htmlunit.HtmlUnitDriver;
import org.openqa.selenium.remote.RemoteWebDriver;

Expand Down Expand Up @@ -84,8 +87,20 @@ private void configureDriverSettings(WebDriver driver) {
driver.manage().timeouts().implicitlyWait(implicitWaitMillis, TimeUnit.MILLISECONDS);
driver.manage().timeouts().pageLoadTimeout(pageLoadTimeoutMillis, TimeUnit.MILLISECONDS);
driver.manage().window().maximize();

configureFirefoxDriver(driver);
}

private void configureFirefoxDriver(WebDriver driver) {
if (driver instanceof FirefoxDriver) {
FirefoxDriver firefoxDriver = (FirefoxDriver) driver;
Capabilities capabilities = firefoxDriver.getCapabilities();
FirefoxOptions options = new FirefoxOptions(capabilities);
// disables extension automatic updates as we don't need it when running the test suite
options.addPreference("extensions.update.enabled", "false");
firefoxDriver.getCapabilities().merge(options);
}
}

public static class HtmlUnitInterceptor implements Interceptor {

Expand Down Expand Up @@ -133,6 +148,6 @@ public Object intercept(InvocationContext context) throws Throwable {
public int getPrecedence() {
return -1;
}
}

}
}
4 changes: 1 addition & 3 deletions ...tion-arquillian/tests/base/src/test/java/org/keycloak/testsuite/AbstractKeycloakTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,7 @@ public void deleteAllCookiesForMasterRealm() {
}

protected void deleteAllCookiesForRealm(String realmName) {
// we can't use /auth/realms/{realmName} because some browsers (e.g. Chrome) apparently don't send cookies
// to JSON pages and therefore can't delete realms cookies there; a non existing page will do just fine
navigateToUri(oauth.SERVER_ROOT + "/auth/realms/" + realmName + "/super-random-page");
navigateToUri(oauth.SERVER_ROOT + "/auth/realms/" + realmName + "/testing/blank");
log.info("deleting cookies in '" + realmName + "' realm");
driver.manage().deleteAllCookies();
}
Expand Down