Adding translations when a new attribute is created #27313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edewit
suggested changes
Feb 28, 2024
Contributor
edewit
left a comment
There was a problem hiding this comment.
just some small nit picks
Comment on lines
312
to
306
Contributor
There was a problem hiding this comment.
why not make the field required?
Contributor
Author
There was a problem hiding this comment.
I think making it required is a better approach.
Comment on lines
279
to
290
Contributor
There was a problem hiding this comment.
This could be changed to a <TextControl
Comment on lines
322
to
332
Contributor
There was a problem hiding this comment.
this can be a TextControl as well
Comment on lines
92
to
94
Contributor
There was a problem hiding this comment.
Suggested change
| newAttributeName !== "" | |
| ? realm?.internationalizationEnabled | |
| ? "${profile.attributes." + `${newAttributeName}}` | |
| : "" | |
| : ""; | |
| newAttributeName !== "" && realm?.internationalizationEnabled ? "${profile.attributes." + `${newAttributeName}}` : ""; |
a758b0f to
985c50b
Compare
91a3374 to
faee51f
Compare
edewit
approved these changes
Mar 4, 2024
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
Signed-off-by: Agnieszka Gancarczyk <[email protected]>
faee51f to
f506151
Compare
jonkoops
approved these changes
Mar 4, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26504