Merged
Conversation
23609cc to
45f6ef3
Compare
jonkoops
reviewed
Jun 17, 2024
45f6ef3 to
0731ab0
Compare
jonkoops
reviewed
Jun 17, 2024
Member
Author
|
@vmuzikar - can you please review and merge this PR? Asking you as it touches the Quarkus |
Member
Author
|
partial_import_test fails randomly: #30492, trying one more time |
0731ab0 to
34fa7d6
Compare
vmuzikar
approved these changes
Jun 17, 2024
Comment on lines
-37
to
42
| <version>${project.version}</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>*</groupId> | ||
| <artifactId>*</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.keycloak</groupId> | ||
| <artifactId>keycloak-quarkus-server-deployment</artifactId> | ||
| <version>${project.version}</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>*</groupId> | ||
| <artifactId>*</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
@pedroigor Do you remember why we excluded this?
Contributor
Also ensure that JS project is not built too often, and the Quarkus distribution is not missed when sub-dependencies change. Closes keycloak#30463 Signed-off-by: Alexander Schwartz <[email protected]>
9e67453 to
f421f9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also ensure that JS project is not built too often, and the Quarkus distribution is not missed when sub-dependencies change.
Closes #30463
How to test:
Run the following command twice. The second time should finish in less than 10 seconds, as it is only calculating hashes and copying cached artifacts to the local Maven repo.
If a source file is then changed (for example
InfinispanCacheRealmProviderFactory.javaorAccountRow.tsx), the final Quarkus ZIP file is rebuilt after building only those dependency that are essential.