Output Vite build directly into Maven target directory#30490
Merged
ahus1 merged 1 commit intokeycloak:mainfrom Jun 19, 2024
Merged
Output Vite build directly into Maven target directory#30490ahus1 merged 1 commit intokeycloak:mainfrom
ahus1 merged 1 commit intokeycloak:mainfrom
Conversation
Signed-off-by: Jon Koops <[email protected]>
Member
|
When doing this, removing the Disadvantage is that it might be annoying while we switch between branches, and the advantage that we'll know if something re-appears in that folder. |
edewit
approved these changes
Jun 19, 2024
Contributor
Author
Looks like some of the libraries still use |
ahus1
approved these changes
Jun 19, 2024
Member
|
Thank you for this simplification - this would also avoid copying around files which might even speed up the build a little. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #30464, see #30464 (comment). Changes the output directory for Vite to the target directory of Maven, mitigating the need to copy these resources in Maven, and simplifying the build cache plugin configuration.