Exchange Enum type of Format for String#30875
Merged
mposolda merged 2 commits intokeycloak:mainfrom Jul 11, 2024
Merged
Conversation
enum-types are a bad choice because it limits the extensibility of the API fixes keycloak#30873 Signed-off-by: Pascal Knüppel <[email protected]>
This was referenced Jun 27, 2024
This was referenced Jul 2, 2024
mposolda
approved these changes
Jul 11, 2024
Contributor
mposolda
left a comment
There was a problem hiding this comment.
@Captain-P-Goldfish @wistefan Thanks for this change and review!
Captain-P-Goldfish
added a commit
to Captain-P-Goldfish/keycloak
that referenced
this pull request
Jul 17, 2024
closes keycloak#30873 Signed-off-by: Pascal Knüppel <[email protected]>
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
closes keycloak#30873 Signed-off-by: Pascal Knüppel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enum-types are a bad choice because it limits the extensibility of the API
fixes #30873
relatesTo #26328