Make ProofType a string instead of enum#31000
Merged
mposolda merged 2 commits intokeycloak:mainfrom Jul 16, 2024
Merged
Conversation
fixes keycloak#30999 relatesTo keycloak#26328 Signed-off-by: Pascal Knüppel <[email protected]>
Contributor
Contributor
|
@mposolda Hello, I will review the PR. |
mposolda
approved these changes
Jul 16, 2024
Contributor
mposolda
left a comment
There was a problem hiding this comment.
@Captain-P-Goldfish @tnorimat Thanks for the PR and review!
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
fixes keycloak#30999 Signed-off-by: Pascal Knüppel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enum-types are a bad choice because it limits the extensibility of the API
fixes #30999
relatesTo #30875
relatesTo #26328