Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add required default-context value to VerifiableCredential #30959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mposolda merged 3 commits into from
Jul 11, 2024
Merged

Add required default-context value to VerifiableCredential #30959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e24ba39
Add required default-context value to VerifiableCredential
Captain-P-Goldfish Jul 1, 2024
4a559b7
Set default VC version to 1
Captain-P-Goldfish Jul 2, 2024
f877558
Merge branch 'main' into vc-context-default
Captain-P-Goldfish Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions services/src/main/java/org/keycloak/protocol/oid4vc/model/VerifiableCredential.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,16 @@
@JsonInclude(JsonInclude.Include.NON_NULL)
public class VerifiableCredential {

public static final String VC_CONTEXT_V1 = "https://www.w3.org/ns/credentials/v1";
public static final String VC_CONTEXT_V2 = "https://www.w3.org/ns/credentials/v2";

/**
* @context: The value of the @context property MUST be an ordered set where the first item is a URL with the
* value https://www.w3.org/ns/credentials/v2. Subsequent items in the ordered set MUST be composed of any
* combination of URLs and/or objects, where each is processable as a JSON-LD Context.
*/
@JsonProperty("@context")
private List<String> context;
private List<String> context = new ArrayList<>(List.of(VC_CONTEXT_V1));
private List<String> type = new ArrayList<>();
private URI issuer;
private Date issuanceDate;
Expand Down Expand Up @@ -127,4 +135,4 @@ public VerifiableCredential setAdditionalProperties(Map<String, Object> addition
this.additionalProperties = additionalProperties;
return this;
}
}
}
3 changes: 3 additions & 0 deletions ...rc/test/java/org/keycloak/testsuite/oid4vc/issuance/signing/OID4VCIssuerEndpointTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,9 @@ public void testRequestCredential() {
assertNotNull("A valid credential string should have been responded", jsonWebToken);
assertNotNull("The credentials should be included at the vc-claim.", jsonWebToken.getOtherClaims().get("vc"));
VerifiableCredential credential = objectMapper.convertValue(jsonWebToken.getOtherClaims().get("vc"), VerifiableCredential.class);
assertNotNull("@context is a required VC property", credential.getContext());
assertEquals(1, credential.getContext().size());
assertEquals(VerifiableCredential.VC_CONTEXT_V1, credential.getContext().get(0));
assertTrue("The static claim should be set.", credential.getCredentialSubject().getClaims().containsKey("VerifiableCredential"));
assertFalse("Only mappers supported for the requested type should have been evaluated.", credential.getCredentialSubject().getClaims().containsKey("AnotherCredentialType"));
}));
Expand Down