Add required default-context value to VerifiableCredential#30959
Merged
mposolda merged 3 commits intokeycloak:mainfrom Jul 11, 2024
Merged
Add required default-context value to VerifiableCredential#30959mposolda merged 3 commits intokeycloak:mainfrom
mposolda merged 3 commits intokeycloak:mainfrom
Conversation
fixes keycloak#30958 Signed-off-by: Pascal Knüppel <[email protected]>
Contributor
Author
|
I just noticed that VerifiableCredential is just a draft and many things are not properly defined yet. So I think we should set the default to version 1 for the time being. |
Version 2 is still in draft and not fully defined Signed-off-by: Pascal Knüppel <[email protected]>
mposolda
approved these changes
Jul 11, 2024
Contributor
mposolda
left a comment
There was a problem hiding this comment.
@Captain-P-Goldfish @wistefan Thanks for the update and review!
Captain-P-Goldfish
added a commit
to Captain-P-Goldfish/keycloak
that referenced
this pull request
Jul 17, 2024
…30959) closes keycloak#30958 Signed-off-by: Pascal Knüppel <[email protected]>
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
…30959) closes keycloak#30958 Signed-off-by: Pascal Knüppel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #30958
relatesTo #26328