Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support for blocking concurrent requests when brute force is enabled #31728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 1 commit into from
Jul 30, 2024
Merged

Support for blocking concurrent requests when brute force is enabled #31728

mposolda merged 1 commit into from
Jul 30, 2024
+217 −14

Conversation

@jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Jul 29, 2024

Closes #31726

@jonkoops jonkoops requested review from a team as code owners July 29, 2024 15:23
@pedroigor @jonkoops
Support for blocking concurrent requests when brute force is enabled
b8862d1 
Closes keycloak#31726

Signed-off-by: Pedro Igor <[email protected]>
Signed-off-by: Douglas Palmer <[email protected]>
Signed-off-by: mposolda <[email protected]>
@jonkoops jonkoops force-pushed the parralel-brute-force branch from 6094798 to b8862d1 Compare July 29, 2024 15:28
mposolda
mposolda approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs is missing in this PR, but not big deal. It was just relatively minor note and should be relatively OK if it is just in the release notes in the blog-post though...

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Jul 29, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testRaceAttackPermanentLockout

Keycloak CI - Forms IT (firefox)

java.lang.AssertionError: Invalid count should be less than or equal 2 but was: 3
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.forms.BruteForceTest.raceAttack(BruteForceTest.java:820)
	at org.keycloak.testsuite.forms.BruteForceTest.testRaceAttackPermanentLockout(BruteForceTest.java:790)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Jul 29, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@mposolda mposolda merged commit a79761a into keycloak:main Jul 30, 2024
@jonkoops jonkoops deleted the parralel-brute-force branch July 31, 2024 15:20
@rmartinc rmartinc added priority/important Must be worked on very soon backport/22.0 labels Aug 8, 2024
This was referenced Aug 8, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test priority/important Must be worked on very soon team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve brute force when handling parallel requests

5 participants

@jonkoops @mposolda @stianst @rmartinc @pedroigor