Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support for blocking concurrent requests when brute force is enabled (22) #31999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mposolda merged 3 commits into from
Aug 9, 2024
Merged

Support for blocking concurrent requests when brute force is enabled (22) #31999

mposolda merged 3 commits into from
Aug 9, 2024

Conversation

@rmartinc
Copy link
Contributor

@rmartinc rmartinc commented Aug 8, 2024

Closes #31726

Backport of PR #31728 into 22. Related issues found after the PR are also backported.

@rmartinc rmartinc requested review from a team as code owners August 8, 2024 06:33
@mposolda mposolda self-assigned this Aug 8, 2024
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Aug 8, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Aug 8, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.DeleteAccountTest#deleteOwnAccountForbiddenWithoutClientRole

Keycloak CI - Account Console IT (firefox)

java.lang.AssertionError: Expected PersonalInfoPage but was Keycloak Account Management (https://localhost:8543/auth/realms/test/account/#/personal-info&state=2bc74f43-a9cb-4ac3-920e-aeca4c4e9b73&session_state=8213eb4f-1f49-4dc4-aeed-e85da92978af&code=6c503c73-c868-4c7c-b4bb-b13de27afd91.8213eb4f-1f49-4dc4-aeed-e85da92978af.f038665e-83c8-4bd9-8c23-004d107a1152)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

org.keycloak.testsuite.forms.BrowserFlowTest#testAlternativeNonInteractiveExecutorInSubflow

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1016-65', ip: '10.1.0.183', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '17.0.12'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1016-65', ip: '10.1.0.183', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '17.0.12'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Aug 9, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Aug 9, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.DeleteAccountTest#deleteOwnAccountForbiddenWithoutClientRole

Keycloak CI - Account Console IT (firefox)

java.lang.AssertionError: Expected PersonalInfoPage but was Keycloak Account Management (https://localhost:8543/auth/realms/test/account/#/personal-info&state=2bc74f43-a9cb-4ac3-920e-aeca4c4e9b73&session_state=8213eb4f-1f49-4dc4-aeed-e85da92978af&code=6c503c73-c868-4c7c-b4bb-b13de27afd91.8213eb4f-1f49-4dc4-aeed-e85da92978af.f038665e-83c8-4bd9-8c23-004d107a1152)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

org.keycloak.testsuite.forms.BrowserFlowTest#testAlternativeNonInteractiveExecutorInSubflow

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1016-65', ip: '10.1.0.183', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '17.0.12'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '3.14.0', revision: 'aacccce0', time: '2018-08-02T20:19:58.91Z'
System info: host: 'fv-az1016-65', ip: '10.1.0.183', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '17.0.12'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

@mposolda mposolda merged commit 0f270db into keycloak:release/22.0 Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmartinc @mposolda @pedroigor