Thanks to visit codestin.com
Credit goes to github.com

Skip to content

move form option wrapper element inside kc-form-options #31223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
edewit merged 1 commit into from
Jul 22, 2024
Merged

move form option wrapper element inside kc-form-options #31223

edewit merged 1 commit into from
Jul 22, 2024

Conversation

@DevDuki
Copy link
Contributor

@DevDuki DevDuki commented Jul 11, 2024

closes #31216

@DevDuki DevDuki requested review from a team as code owners July 11, 2024 13:46
@thomasdarimont
Copy link
Contributor

thomasdarimont commented Jul 16, 2024

@DevDuki thanks for your PR! Could you please add the DCR (sign off information to your commit?)

git commit --amend --signoff

@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Jul 17, 2024
Closed
@thomasdarimont
Copy link
Contributor

thomasdarimont commented Jul 17, 2024 •
edited
Loading

Could you perhaps rebase your commit on top of the current main instead of doing a merge commit?

git checkout main
git pull upstream main --rebase

Remove the merge commit, e.g. by doing:

git rebase -i HEAD~2
comment out the line with the merge commit
exit the editor,e .g. `:wq`

then

git checkout correctly-wrap-form-options-in-login-password
git rebase main
git commit --amend --signoff

Then git push -f origin correctly-wrap-form-options-in-login-password

@DevDuki DevDuki force-pushed the correctly-wrap-form-options-in-login-password branch 2 times, most recently from 2c54443 to 126c12a Compare July 17, 2024 08:04
@DevDuki DevDuki force-pushed the correctly-wrap-form-options-in-login-password branch from 126c12a to b57a5d0 Compare July 17, 2024 08:07
@edewit edewit merged commit 10fc2e9 into keycloak:main Jul 22, 2024
lhanusov pushed a commit to lhanusov/keycloak that referenced this pull request Jul 22, 2024
@DevDuki @lhanusov
move form option wrapper element inside kc-form-options (keycloak#31223)
15f69ae 
closes keycloak#31216

Signed-off-by: Dusan Misic <[email protected]>
Co-authored-by: Dusan Misic <[email protected]>
Signed-off-by: Lukas Hanusovsky <[email protected]>
@DevDuki DevDuki deleted the correctly-wrap-form-options-in-login-password branch July 23, 2024 05:56
@stianst stianst mentioned this pull request Jul 25, 2024
Closed
stianst pushed a commit to stianst/keycloak that referenced this pull request Jul 25, 2024
@DevDuki @stianst
move form option wrapper element inside kc-form-options (keycloak#31223)
da8250c 
closes keycloak#31216

Signed-off-by: Dusan Misic <[email protected]>
Co-authored-by: Dusan Misic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@edewit edewit edewit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#kc-form-options div not wrapping its content correctly in login-password.ftl

3 participants

@DevDuki @thomasdarimont @edewit