move form option wrapper element inside kc-form-options#31223
Merged
edewit merged 1 commit intokeycloak:mainfrom Jul 22, 2024
Merged
move form option wrapper element inside kc-form-options#31223edewit merged 1 commit intokeycloak:mainfrom
edewit merged 1 commit intokeycloak:mainfrom
Conversation
Contributor
|
@DevDuki thanks for your PR! Could you please add the DCR (sign off information to your commit?) |
Contributor
|
Could you perhaps rebase your commit on top of the current main instead of doing a merge commit? Remove the merge commit, e.g. by doing: then Then |
2c54443 to
126c12a
Compare
closes keycloak#31216 Signed-off-by: Dusan Misic <[email protected]>
126c12a to
b57a5d0
Compare
edewit
approved these changes
Jul 22, 2024
lhanusov
pushed a commit
to lhanusov/keycloak
that referenced
this pull request
Jul 22, 2024
closes keycloak#31216 Signed-off-by: Dusan Misic <[email protected]> Co-authored-by: Dusan Misic <[email protected]> Signed-off-by: Lukas Hanusovsky <[email protected]>
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Jul 25, 2024
closes keycloak#31216 Signed-off-by: Dusan Misic <[email protected]> Co-authored-by: Dusan Misic <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #31216