Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added template overrides #32082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ssilvert merged 4 commits into from
Aug 16, 2024
Merged

Added template overrides #32082

ssilvert merged 4 commits into from
Aug 16, 2024

Conversation

@edewit
Copy link
Contributor

@edewit edewit commented Aug 13, 2024

This will redo the rolled back changes from PR #31106.
Now that the tests run on this we can make sure nothing breaks

  • Added template overrides
  • pr review comment
  • *** removed duplicated javascript and fixed formatting * addressed PR comments**

edewit added 3 commits August 13, 2024 11:04
@edewit
Added template overrides
5dd184e 
fixes: keycloak#31021
Signed-off-by: Erik Jan de Wit <[email protected]>
@edewit
pr review comment
90f3347 
Signed-off-by: Erik Jan de Wit <[email protected]>
@edewit
* removed duplicated javascript and fixed formatting
cada1ae 
* addressed PR comments

Signed-off-by: Erik Jan de Wit <[email protected]>
@edewit edewit requested review from a team as code owners August 13, 2024 09:07
@edewit edewit self-assigned this Aug 13, 2024
ssilvert
ssilvert previously approved these changes Aug 15, 2024
View reviewed changes
@edewit
added properties for classes
977eaa8 
Signed-off-by: Erik Jan de Wit <[email protected]>
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Aug 16, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Aug 16, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: Did not find the event of expected type USER_DISABLED_BY_TEMPORARY_LOCKOUT. Events present: [IDENTITY_PROVIDER_POST_LOGIN_ERROR, IDENTITY_PROVIDER_POST_LOGIN_ERROR]
	at org.junit.Assert.fail(Assert.java:89)
	at org.keycloak.testsuite.AssertEvents$ExpectedEvent.assertEvent(AssertEvents.java:399)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:584)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

@ssilvert ssilvert merged commit 3ddc3fd into keycloak:main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ssilvert ssilvert ssilvert approved these changes

+1 more reviewer

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edewit @ssilvert