Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure hide_on_login has the default value set to 0 on MSSQL #34515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedroigor merged 2 commits into from
Oct 31, 2024
Merged

Ensure hide_on_login has the default value set to 0 on MSSQL #34515

pedroigor merged 2 commits into from
Oct 31, 2024

Conversation

@sguilhen
Copy link
Contributor

@sguilhen sguilhen commented Oct 30, 2024

Closes #34450

Signed-off-by: Stefan Guilhen [email protected]
(cherry picked from commit ac25844)

@sguilhen sguilhen requested a review from a team as a code owner October 30, 2024 15:57
pedroigor
pedroigor previously approved these changes Oct 30, 2024
View reviewed changes
@pedroigor pedroigor enabled auto-merge (rebase) October 30, 2024 17:02
@pedroigor pedroigor disabled auto-merge October 30, 2024 17:06
@pedroigor
Copy link
Contributor

pedroigor commented Oct 30, 2024

@rmartinc Do we need anything else ?

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 30, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 30, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButton

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"*[name='login']"}
  (Session info: chrome=130.0.6723.58)
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.21.0', revision: '79ed462ef4'
...

Report flaky test

rmartinc
rmartinc suggested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@rmartinc rmartinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested and a previously keycloak at version 26.0.2 complains with the following message whe upgrading to current 999:

Caused by: liquibase.exception.ValidationFailedException: Validation Failed:
     1 changesets check sum
          META-INF/jpa-changelog-26.0.0.xml::26.0.0-idps-for-login::keycloak was: 9:51f5fffadf986983d4bd59582c6c1604 but is now: 9:ac427966f1e52713b0c97a88b8d1351d

So we need to add the 9:51f5fffadf986983d4bd59582c6c1604 as valid checksums for that task.

pedroigor
pedroigor reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@pedroigor pedroigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting #34521.

@pedroigor pedroigor self-requested a review October 30, 2024 20:50
@pedroigor pedroigor dismissed their stale review October 30, 2024 20:51

Waiting for #34521.

@mhajas mhajas added the status/hold PR should not be merged. On hold for later. label Oct 31, 2024
@sguilhen sguilhen force-pushed the backport-34500-26.0 branch from 66e4ef7 to 2245a47 Compare October 31, 2024 11:22
@sguilhen sguilhen requested a review from rmartinc October 31, 2024 11:23
@sguilhen
Copy link
Contributor Author

sguilhen commented Oct 31, 2024

@rmartinc @pedroigor updated this PR to also include the commit that adds the valid checksum to jpa-changelog-26.0.0.xml

@sguilhen sguilhen removed the status/hold PR should not be merged. On hold for later. label Oct 31, 2024
rmartinc
rmartinc approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@rmartinc rmartinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankd @sguilhen !

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 31, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 31, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

org.keycloak.testsuite.broker.KcSamlBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - FIPS IT (non-strict)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@pedroigor pedroigor merged commit 07a92c5 into keycloak:release/26.0 Oct 31, 2024
65 checks passed
@sguilhen sguilhen deleted the backport-34500-26.0 branch December 12, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@rmartinc rmartinc rmartinc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sguilhen @pedroigor @rmartinc @mhajas