Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add validChecksum to jpa-changelog-26.0.0.xml #34521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pedroigor merged 1 commit into from
Oct 31, 2024
Merged

Add validChecksum to jpa-changelog-26.0.0.xml #34521

pedroigor merged 1 commit into from
Oct 31, 2024

Conversation

@sguilhen
Copy link
Contributor

@sguilhen sguilhen commented Oct 30, 2024

Closes #34450

@sguilhen sguilhen requested a review from a team as a code owner October 30, 2024 19:19
@sguilhen
Copy link
Contributor Author

sguilhen commented Oct 30, 2024

@rmartinc I've tested an upgrade from 26.0.0 and now it works fine, doesn't complain about the checksum

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Oct 30, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Oct 30, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.actions.TermsAndConditionsTest#termsDeclined

Keycloak CI - Base IT (1)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.actions.TermsAndConditionsTest.termsDeclined(TermsAndConditionsTest.java:170)
...

Report flaky test

@pedroigor pedroigor mentioned this pull request Oct 30, 2024
Merged
rmartinc
rmartinc approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@rmartinc rmartinc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sguilhen!

@pedroigor pedroigor merged commit 9c50813 into keycloak:main Oct 31, 2024
70 checks passed
@shawkins shawkins mentioned this pull request Feb 25, 2025
Closed
@sguilhen sguilhen deleted the 34450-mssql-hide-on-login branch December 12, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@rmartinc rmartinc rmartinc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[26.0.2] Migration from 25.0.1 Identity Provider Errors

3 participants

@sguilhen @pedroigor @rmartinc