Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a realm-level setting to enable FGAP to a realm#35043

Merged
pedroigor merged 1 commit intokeycloak:mainfrom
vramik:34920-fgap-switch
Nov 19, 2024
Merged

Add a realm-level setting to enable FGAP to a realm#35043
pedroigor merged 1 commit intokeycloak:mainfrom
vramik:34920-fgap-switch

Conversation

@vramik
Copy link
Contributor

@vramik vramik commented Nov 18, 2024

Closes #34920

@vramik vramik requested review from a team as code owners November 18, 2024 12:09
@vramik
Copy link
Contributor Author

vramik commented Nov 18, 2024

@agagancarczyk would you please take a look from UI POV?

@vramik vramik requested a review from agagancarczyk November 18, 2024 14:02
@pedroigor
Copy link
Contributor

pedroigor commented Nov 18, 2024

If I understand correctly, the only thing missing in the UI now is to hide/show the Permissions tab?

@vramik
Copy link
Contributor Author

vramik commented Nov 18, 2024

If I understand correctly, the only thing missing in the UI now is to hide/show the Permissions tab?

It you mean showing the realm-management's authorization services, then yes. And it should be done within #34566. Showing a new client would be possible only after #34565.

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Nov 18, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

keycloak-github-bot bot commented Nov 18, 2024

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.RoleInvalidationClusterTest#crudWithoutFailover

Keycloak CI - Clustering IT

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

jakarta.ws.rs.ForbiddenException: HTTP 403 Forbidden
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:240)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.cluster.RoleInvalidationClusterTest#crudWithFailover

Keycloak CI - Clustering IT

jakarta.ws.rs.ForbiddenException: HTTP 403 Forbidden
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:240)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

agagancarczyk
agagancarczyk approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@agagancarczyk agagancarczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes look good!

@pedroigor pedroigor merged commit 440e81c into keycloak:main Nov 19, 2024
@vramik vramik deleted the 34920-fgap-switch branch November 19, 2024 13:46
@agagancarczyk agagancarczyk mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedroigor pedroigor pedroigor approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@agagancarczyk agagancarczyk agagancarczyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam team/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FGAP] Add a realm-level setting to enable FGAP to a realm

3 participants

@vramik @pedroigor @agagancarczyk