Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix knative-monitoring namespace and accessing-logs URL #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2018
Merged

Fix knative-monitoring namespace and accessing-logs URL #437

merged 1 commit into from
Oct 9, 2018

Conversation

@vdemeester
Copy link
Contributor

The namespace is knative-monitoring instead of monitoring

Signed-off-by: Vincent Demeester [email protected]

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2018
@vaikas
Copy link
Contributor

vaikas commented Oct 4, 2018

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 4, 2018
@vdemeester
Copy link
Contributor Author

Hum, elsewhere in the docs, there is reference to monitor namespace too… I'm gonna check the serving yaml to deploy it to see which namespace there on

@vdemeester
Fix accessing-logs URL
21889a5 
The namespace is `knative-monitoring` instead of `monitoring`

Signed-off-by: Vincent Demeester <[email protected]>
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2018
@vdemeester vdemeester changed the title Fix accessing-logs URL Fix knative-monitoring namespace and accessing-logs URL Oct 4, 2018
@vdemeester
Copy link
Contributor Author

/test pull-knative-docs-integration-tests

@samodell
Copy link
Contributor

samodell commented Oct 4, 2018

/retest

@vdemeester
Copy link
Contributor Author

/test pull-knative-docs-integration-tests

@bbrowning
Copy link
Contributor

The integration test failure was unrelated to this change and due to an issue impacting all PRs in the docs repo that is now fixed.

/test pull-knative-docs-integration-tests

@vaikas
Copy link
Contributor

vaikas commented Oct 9, 2018

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2018
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas-google, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit af3d2d8 into knative:master Oct 9, 2018
@vdemeester vdemeester deleted the fix-accessing-logs branch October 9, 2018 14:15
@RichieEscarez RichieEscarez mentioned this pull request Oct 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgregg rgregg Awaiting requested review from rgregg

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@vaikas vaikas

Labels

lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vdemeester @vaikas @samodell @bbrowning @knative-prow-robot