Add EventTransform Jsonata reconciler and CRD #8456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8456 +/- ##
==========================================
- Coverage 63.91% 63.00% -0.91%
==========================================
Files 391 394 +3
Lines 23543 23882 +339
==========================================
Hits 15048 15048
- Misses 7691 8030 +339
Partials 804 804 ☔ View full report in Codecov by Sentry. |
matzew
reviewed
Feb 12, 2025
| registry.Register(&flowsv1.Sequence{}) | ||
| registry.Register(&flowsv1.Parallel{}) | ||
| registry.Register(&eventingv1alpha1.EventPolicy{}) | ||
| registry.Register(&eventingv1alpha1.EventTransform{}) |
There was a problem hiding this comment.
was this used to generate the actual CRD?
Asking because other new CRDs (e.g. JobSink or Integration source/sink are missing.
(I can add them in a separate PR)
There was a problem hiding this comment.
Partially, this is to generate the schema part of the CRD
There was a problem hiding this comment.
but it's only for bootstrapping it to give an head start
go run ./cmd/schema/ dump EventTransform
matzew
reviewed
Feb 12, 2025
| sourceslisters "knative.dev/eventing/pkg/client/listers/sources/v1" | ||
| ) | ||
|
|
||
| type Reconciler struct { |
There was a problem hiding this comment.
nit: we could include a _test.go file. But can be done on separate PR
There was a problem hiding this comment.
Yes, I'll follow up with unit and e2e tests
matzew
reviewed
Feb 12, 2025
| @@ -0,0 +1,176 @@ | |||
| package eventtransform | |||
There was a problem hiding this comment.
nit: we could license header? and perhaps stash that file in a separate resources folder? Like others do?
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Pierangelo Di Pilato <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test reconciler-tests |
matzew
pushed a commit
to matzew/eventing
that referenced
this pull request
Mar 18, 2025
* Add EventTransform Jsonata reconciler Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add CRD Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add reconciler to controller binary Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add permissions Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add selector to eventing filtered factory Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add License header Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add symlink Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]>
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Mar 18, 2025
* Add EventTransform API types (knative#8447) * Add EventTransform API Signed-off-by: Pierangelo Di Pilato <[email protected]> * Codegen Signed-off-by: Pierangelo Di Pilato <[email protected]> * Rename TransformList -> EventTransformList Signed-off-by: Pierangelo Di Pilato <[email protected]> * Fix lint errors Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add EventTransform Jsonata reconciler and CRD (knative#8456) * Add EventTransform Jsonata reconciler Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add CRD Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add reconciler to controller binary Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add permissions Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add selector to eventing filtered factory Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add License header Signed-off-by: Pierangelo Di Pilato <[email protected]> * Add symlink Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]> * EventTransform: Reconcile address and service (knative#8458) - Set address only once endpoints are available - Add debug logging - Fix semantic comparisons to avoid loops Signed-off-by: Pierangelo Di Pilato <[email protected]> * EventTransform: Support transforming response from Sink (knative#8469) This allows: - propagating the response from Sink - discarding the response from Sink - transforming the response from Sink Signed-off-by: Pierangelo Di Pilato <[email protected]> * chore: Adding missing sinks and sources to schema file (knative#8460) :lipstick: Adding missing sinks and sources to schema file Signed-off-by: Matthias Wessendorf <[email protected]> * Run make generate-release Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Pierangelo Di Pilato <[email protected]> Signed-off-by: Matthias Wessendorf <[email protected]> Co-authored-by: Pierangelo Di Pilato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Proposed Changes
Pre-review Checklist
Release Note
Docs