Thanks to visit codestin.com
Credit goes to github.com

Skip to content

EventTransform: Reconcile address and service #8458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

EventTransform: Reconcile address and service #8458

merged 1 commit into from
Feb 13, 2025

Conversation

@pierDipi
Copy link
Member

@pierDipi pierDipi commented Feb 12, 2025 •
edited
Loading

  • Set address only once endpoints are available
  • Add debug logging
  • Fix semantic comparisons to avoid loops

It's now fully working end to end.

Related to:

Proposed Changes

  • Set address only once endpoints are available
  • Add debug logging
  • Fix semantic comparisons to avoid loops

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 12, 2025
@knative-prow
Copy link

knative-prow bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@pierDipi pierDipi force-pushed the eventtransform-jsonata-reconciler-service branch 2 times, most recently from 07e71d0 to af68e76 Compare February 12, 2025 18:35
@pierDipi
EventTransform: Reconcile address and service
6c32b4a 
- Set address only once endpoints are available
- Add debug logging
- Fix semantic comparisons to avoid loops

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi pierDipi force-pushed the eventtransform-jsonata-reconciler-service branch from af68e76 to 6c32b4a Compare February 12, 2025 18:48
@codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 161 lines in your changes missing coverage. Please review.

Project coverage is 62.68%. Comparing base (779992f) to head (6c32b4a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/eventtransform/eventtransform.go 0.00% 96 Missing ⚠️
pkg/reconciler/eventtransform/resources_jsonata.go 0.00% 41 Missing ⚠️
pkg/reconciler/eventtransform/controller.go 0.00% 18 Missing ⚠️
...pis/eventing/v1alpha1/eventtransform_validation.go 0.00% 3 Missing ⚠️
...apis/eventing/v1alpha1/eventtransform_lifecycle.go 0.00% 2 Missing ⚠️
.../apis/eventing/v1alpha1/eventtransform_defaults.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8458      +/-   ##
==========================================
- Coverage   63.02%   62.68%   -0.34%     
==========================================
  Files         394      395       +1     
  Lines       23882    24009     +127     
==========================================
  Hits        15051    15051              
- Misses       8028     8155     +127     
  Partials      803      803

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Feb 13, 2025
Closed
Closed
Closed
creydr
creydr reviewed Feb 13, 2025
View reviewed changes
config/core/deployments/controller.yaml
fieldPath: metadata.name

- name: EVENT_TRANSFORM_JSONATA_IMAGE
value: quay.io/pierdipi/jsonata-transform@sha256:6aafed0012b8a3c24a1cd72fc4521981ec7680cf64988c22ded0aafa2a431c93
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a left over, or don't we have yet a built of https://github.com/knative-extensions/eventing-integrations/tree/main/transform-jsonata

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have that, that repo builds only the integration bits (which are also on latest, still in eventing 🙈 )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on that, I'll PR the build + usage soon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other comments?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@pierDipi
Copy link
Member Author

/retest

@pierDipi
Copy link
Member Author

/test unit-tests

@knative-prow knative-prow bot merged commit 75195a5 into knative:main Feb 13, 2025
35 of 36 checks passed
matzew pushed a commit to matzew/eventing that referenced this pull request Mar 18, 2025
@pierDipi @matzew
EventTransform: Reconcile address and service (knative#8458)
d2fe99f 
- Set address only once endpoints are available
- Add debug logging
- Fix semantic comparisons to avoid loops

Signed-off-by: Pierangelo Di Pilato <[email protected]>
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Mar 18, 2025
@matzew @pierDipi
Transformer backports ocp 1.17 part i (#1198)
b67fdb9 
* Add EventTransform API types (knative#8447)

* Add EventTransform API

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Codegen

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Rename TransformList -> EventTransformList

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Fix lint errors

Signed-off-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add EventTransform Jsonata reconciler and CRD (knative#8456)

* Add EventTransform Jsonata reconciler

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add CRD

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add reconciler to controller binary

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add permissions

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add selector to eventing filtered factory

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add License header

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* Add symlink

Signed-off-by: Pierangelo Di Pilato <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* EventTransform: Reconcile address and service (knative#8458)

- Set address only once endpoints are available
- Add debug logging
- Fix semantic comparisons to avoid loops

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* EventTransform: Support transforming response from Sink (knative#8469)

This allows:
- propagating the response from Sink
- discarding the response from Sink
- transforming the response from Sink

Signed-off-by: Pierangelo Di Pilato <[email protected]>

* chore: Adding missing sinks and sources to schema file (knative#8460)

:lipstick: Adding missing sinks and sources to schema file

Signed-off-by: Matthias Wessendorf <[email protected]>

* Run make generate-release

Signed-off-by: Matthias Wessendorf <[email protected]>

---------

Signed-off-by: Pierangelo Di Pilato <[email protected]>
Signed-off-by: Matthias Wessendorf <[email protected]>
Co-authored-by: Pierangelo Di Pilato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creydr creydr creydr left review comments

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees

@creydr creydr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pierDipi @matzew @creydr