Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Compare the entire PodTemplateSpec, instead of just its PodSpec #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Compare the entire PodTemplateSpec, instead of just its PodSpec #8558

merged 1 commit into from
Apr 14, 2025

Conversation

@matzew
Copy link
Member

@matzew matzew commented Apr 14, 2025 •
edited
Loading

Fixes #8547

Proposed Changes

  • Compare the entire PodTemplateSpec, instead of just its PodSpec

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

ContainerSource now compares the entire PodTemplateSpec, instead of just its PodSpec. This avoids loosing edits on metadata, like annotations

Docs

@knative-prow knative-prow bot requested review from Cali0707 and pierDipi April 14, 2025 13:07
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.31%. Comparing base (f14c335) to head (3680759).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/containersource/containersource.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8558      +/-   ##
==========================================
- Coverage   52.33%   52.31%   -0.03%     
==========================================
  Files         397      397              
  Lines       24923    24925       +2     
==========================================
- Hits        13043    13039       -4     
- Misses      11094    11099       +5     
- Partials      786      787       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matzew
Copy link
Member Author

matzew commented Apr 14, 2025

/override codecov/project

@knative-prow
Copy link

knative-prow bot commented Apr 14, 2025

@matzew: Overrode contexts on behalf of matzew: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew matzew mentioned this pull request Apr 14, 2025
Closed
@matzew
Copy link
Member Author

matzew commented Apr 14, 2025

/hold
wait for reviews

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025
pierDipi
pierDipi approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@knative-prow
Copy link

knative-prow bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented Apr 14, 2025

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2025
@matzew
Copy link
Member Author

matzew commented Apr 14, 2025

/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member Author

matzew commented Apr 14, 2025

/cherry-pick release-1.16

@knative-prow-robot
Copy link
Contributor

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 5f466ad into knative:main Apr 14, 2025
36 of 37 checks passed
@knative-prow-robot
Copy link
Contributor

@matzew: new pull request created: #8560

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Apr 14, 2025
Merged
@knative-prow-robot
Copy link
Contributor

@matzew: new pull request created: #8561

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@pierDipi pierDipi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Annotations from container source not applied to kubernetes deployment

3 participants

@matzew @knative-prow-robot @pierDipi