Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.16] Compare the entire PodTemplateSpec, instead of just its PodSpec #8561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

[release-1.16] Compare the entire PodTemplateSpec, instead of just its PodSpec #8561

merged 1 commit into from
Apr 15, 2025

Conversation

@knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #8558

ContainerSource now compares the entire PodTemplateSpec, instead of just its PodSpec. This avoids loosing edits on metadata, like annotations

@knative-prow-robot knative-prow-robot mentioned this pull request Apr 14, 2025
Merged
5 tasks
@knative-prow knative-prow bot requested review from aliok and pierDipi April 14, 2025 18:09
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2025
@codecov
Copy link

codecov bot commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.10%. Comparing base (81e5fe7) to head (0be2860).
Report is 1 commits behind head on release-1.16.

Files with missing lines Patch % Lines
pkg/reconciler/containersource/containersource.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.16    #8561      +/-   ##
================================================
- Coverage         53.11%   53.10%   -0.01%     
================================================
  Files               359      359              
  Lines             22112    22114       +2     
================================================
- Hits              11744    11743       -1     
- Misses             9675     9678       +3     
  Partials            693      693

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creydr
Copy link
Member

creydr commented Apr 15, 2025

Code style action probably needs #8562

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/retest

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/override "Code Style / style / Golang / Lint"

@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

@matzew: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Code Style / style / Golang / Lint

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • build-tests_eventing_release-1.16
  • codecov/project
  • conformance-tests_eventing_release-1.16
  • reconciler-tests_eventing_release-1.16
  • style / Golang / Auto-format and Check
  • style / Golang / Lint
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_eventing_release-1.16
  • upgrade-tests_eventing_release-1.16

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Code Style / style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/override "style / Golang / Lint"

@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

@matzew: Overrode contexts on behalf of matzew: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/override "codecov/project"

@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

@matzew: Overrode contexts on behalf of matzew: codecov/project

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 15, 2025

/override "style / Golang / Auto-format and Check"

@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

@matzew: Overrode contexts on behalf of matzew: style / Golang / Auto-format and Check

In response to this:

/override "style / Golang / Auto-format and Check"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

matzew
matzew approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
@knative-prow
Copy link

knative-prow bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2025
@knative-prow knative-prow bot merged commit ce38f72 into knative:release-1.16 Apr 15, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@matzew matzew

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@knative-prow-robot @creydr @matzew