Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: make deploy-dev for development env#4881

Merged
Jooho merged 3 commits intokserve:masterfrom
Jooho:fix_deploy_dev
Jan 2, 2026
Merged

fix: make deploy-dev for development env#4881
Jooho merged 3 commits intokserve:masterfrom
Jooho:fix_deploy_dev

Conversation

@Jooho
Copy link
Contributor

@Jooho Jooho commented Dec 6, 2025

What this PR does / why we need it:

  • Remove self-signed certificate part for deploy-dev target.
    • Since we already have a script that installs cert-manager, using it doesn’t add much cost. We can also use the new script when installing KServe, so keeping the self-signed certificate option doesn’t seem necessary. That’s why I think removing this option is the better choice.
  • Add a new Makefile target redeploy-dev-image to build new images and redeploy them
  • Add new scripsts
    • Install Kind cli(install-kind.sh)
      • Add kind cli version to kserve-deps.env
    • Deploy kind cluster with local registry using docker. (manage.kind-with-registry.sh)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

@Jooho Jooho marked this pull request as draft December 6, 2025 02:04
@Jooho Jooho marked this pull request as ready for review December 6, 2025 02:16
@Jooho Jooho changed the title [WIP] fix: make deploy-dev for development env fix: make deploy-dev for development env Dec 6, 2025
- Remove self-signed certificate part for deploy-dev target.
- Add a new Makefile target `redeploy-dev-image` to build new images and redeploy them
- Add new scripsts
  - Install Kind cli(install-kind.sh)
    - Add kind cli version to kserve-deps.env
  - Deploy kind cluster with local registry using docker. (manage.kind-with-registry.sh)

Signed-off-by: Jooho Lee <[email protected]>
FLAKE8_LINT_VERSION=7.1
POETRY_VERSION=1.8.3
UV_VERSION=0.7.8
KIND_VERSION=v0.30.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we centralize these envs in the kserve-deps.env and load them where it is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything I’ve enhanced so far has been about centralizing things. The reason is that many scripts were using different versions of the same packages, which caused issues. So I believe it’s meaningful to consolidate all dependencies into a single file.

@Jooho Jooho merged commit f44cb66 into kserve:master Jan 2, 2026
68 checks passed
@Jooho Jooho deleted the fix_deploy_dev branch January 2, 2026 17:30
spolti added a commit to spolti/kserve that referenced this pull request Jan 29, 2026
Commits in this batch:
35755fc ci: PR style check (kserve#4499)
30d1b75 AIOHTTP's HTTP Parser auto_decompress feature is vulnerable to zip bomb (kserve#4939)
53004e7 (jooho/upstream_master) feat: add automatic modelFormat annotation for InferenceServices (kserve#4953)
7d10530 Bump Gateway API Inference Extension (GIE) to v1.2.0 (kserve#4886)
b43d60c Separate LocalModelCache webhook from KServe controller. (kserve#4941)
58fa35d Fix CVE-2025-68156: Update expr-lang/expr to v1.17.7 (kserve#4934)
7a7c5aa refactor: deduplicate test configs with helper functions (kserve#4952)
6f95f1a Fix: use correct image tag in LLMISvc E2E workflow (kserve#4948)
f1f7bed Fix: LLMInferenceService reconciliation for Gateway refs in baseRefs (kserve#4944)
a70985a CVE-2025-66418 - Unbounded number of links in the decompression chain (kserve#4928)
11aad94 chore: bump github.com/kedacore/keda/v2 from 2.16.1 to 2.17.3 (kserve#4927)
b253a50 Fix: opentelemetry helm installation script (kserve#4932)
4041412 refactor: replace bash script with Python and improve generate-version (kserve#4935)
2e987ef Add precommit check to sync golangci Go version with go.mod (kserve#4930)
f44cb66 fix: make deploy-dev for development env (kserve#4881)
f15f6ac Address several CVEs (kserve#4912)
54faf3b ci: add retry request for e2e tests to reduce transient failures (kserve#4795)
6b7bc43 chore: Add .gitattributes to mark vendored and generated code (kserve#4904)
29a6a2b ci: split KServe and Storage  publish workflow into separate jobs (kserve#4801)
299706d Improved CA Bundle Management For LLM Inference Services (kserve#4803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants