Fix: use correct image tag in LLMISvc E2E workflow#4948
Merged
Jooho merged 2 commits intokserve:masterfrom Jan 12, 2026
Merged
Conversation
The workflow was patching the deployment to use an image tag that wasn't loaded into minikube. The image is loaded as 'local-test' but the patch was using the github.sha tag. Also change from `kubectl wait --for=condition=available` to `kubectl rollout status` to ensure the new pod is ready, not just the old one during rolling update. Signed-off-by: Pierangelo Di Pilato <[email protected]>
ba0051a to
f860bad
Compare
spolti
reviewed
Jan 12, 2026
| # Use 'local-test' tag since that's what was loaded into minikube | ||
| kubectl patch deployment kserve-llmisvc-controller-manager -n kserve \ | ||
| -p '{"spec":{"template":{"spec":{"containers":[{"name":"manager","image":"'${LLMISVC_CONTROLLER_IMG_TAG}'","imagePullPolicy":"Never"}]}}}}' | ||
| -p '{"spec":{"template":{"spec":{"containers":[{"name":"manager","image":"kserve/llmisvc-controller:local-test","imagePullPolicy":"Never"}]}}}}' |
Contributor
There was a problem hiding this comment.
is it fine to hard-code it?
in this case, we don't need this env LLMISVC_CONTROLLER_IMG_TAG anymore, right?
Member
Author
There was a problem hiding this comment.
yes, it's hardcoded in a previous step
echo "🐳 Tagging and loading LLMISvc controller image into minikube..."
# Load the image from the tar file
docker load -i ./tmp/llmisvc-controller-${{ github.sha }}
# Tag the loaded image as kserve/llmisvc-controller:local-test
IMAGE_ID=$(docker images --format "{{.Repository}}:{{.Tag}} {{.ID}}" | grep llmisvc-controller | awk '{print $2}' | head -n1)
docker tag $IMAGE_ID kserve/llmisvc-controller:local-test
# Load the tagged image into minikube
minikube image load kserve/llmisvc-controller:local-test
f860bad to
571a513
Compare
Member
Author
|
/rerun-workflow "Python package" |
Member
Author
|
/rerun-workflow "Python package" |
spolti
approved these changes
Jan 12, 2026
Contributor
spolti
left a comment
There was a problem hiding this comment.
It will be updated to use the env in another PR.
Approving for now.
/lgtm
agoston
pushed a commit
to agoston/kserve
that referenced
this pull request
Jan 15, 2026
Signed-off-by: Pierangelo Di Pilato <[email protected]> Signed-off-by: Horvath Agoston <[email protected]>
spolti
added a commit
to spolti/kserve
that referenced
this pull request
Jan 29, 2026
Commits in this batch: 35755fc ci: PR style check (kserve#4499) 30d1b75 AIOHTTP's HTTP Parser auto_decompress feature is vulnerable to zip bomb (kserve#4939) 53004e7 (jooho/upstream_master) feat: add automatic modelFormat annotation for InferenceServices (kserve#4953) 7d10530 Bump Gateway API Inference Extension (GIE) to v1.2.0 (kserve#4886) b43d60c Separate LocalModelCache webhook from KServe controller. (kserve#4941) 58fa35d Fix CVE-2025-68156: Update expr-lang/expr to v1.17.7 (kserve#4934) 7a7c5aa refactor: deduplicate test configs with helper functions (kserve#4952) 6f95f1a Fix: use correct image tag in LLMISvc E2E workflow (kserve#4948) f1f7bed Fix: LLMInferenceService reconciliation for Gateway refs in baseRefs (kserve#4944) a70985a CVE-2025-66418 - Unbounded number of links in the decompression chain (kserve#4928) 11aad94 chore: bump github.com/kedacore/keda/v2 from 2.16.1 to 2.17.3 (kserve#4927) b253a50 Fix: opentelemetry helm installation script (kserve#4932) 4041412 refactor: replace bash script with Python and improve generate-version (kserve#4935) 2e987ef Add precommit check to sync golangci Go version with go.mod (kserve#4930) f44cb66 fix: make deploy-dev for development env (kserve#4881) f15f6ac Address several CVEs (kserve#4912) 54faf3b ci: add retry request for e2e tests to reduce transient failures (kserve#4795) 6b7bc43 chore: Add .gitattributes to mark vendored and generated code (kserve#4904) 29a6a2b ci: split KServe and Storage publish workflow into separate jobs (kserve#4801) 299706d Improved CA Bundle Management For LLM Inference Services (kserve#4803)
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow was patching the deployment to use an image tag that wasn't loaded into minikube. The image is loaded as 'local-test' but the patch was using the github.sha tag.
Also change from
kubectl wait --for=condition=availabletokubectl rollout statusto ensure the new pod is ready, not just the old one during rolling update.Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.